fix(nav): hide experimental-site banner when no legacy site configured - #406
Merged
Merged
Conversation
…ured ORG.websiteLegacy is empty for evig (no legacy site), but the mobile menu's "Experimentelle Site – zur aktuellen Site" banner rendered unconditionally with a link to an empty href. Gate it on ORG.websiteLegacy so it only shows when a legacy site exists to link to, matching the intent already documented on that config field. Reported by a visitor via the site feedback widget. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ORG.websiteLegacyis''for evig (no legacy site — see the comment on that field insrc/config/org.ts), butMobileMenu.tsxrendered the banner unconditionally, linking to an emptyhref.ORG.websiteLegacybeing truthy, matching the config comment's original intent.Test plan
npm run typecheck— passnpx eslint src/components/layout/MobileMenu.tsx— pass🤖 Generated with Claude Code